-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[DRAFT] Workers Tracing / Exporting OTel #24713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm once TODOs are resolved. thanks @nevikashah
|
|
||
| Cloudflare has automatically instrumented fetch calls and requests to Cloudflare resources (e.g. Workers KV, D1 Databases, Durable Objects) bound to your Workers application, without requiring you to install and configure an OpenTelemetry SDK. | ||
|
|
||
| **TO-DO:** add defintions to each span and attribute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very important! Thank you in advance for filling in the docs.
src/content/docs/workers/observability/traces/known-limitations.md
Outdated
Show resolved
Hide resolved
src/content/docs/workers/observability/traces/known-limitations.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this leaking Issues as a feature?
src/content/docs/workers/observability/traces/known-limitations.md
Outdated
Show resolved
Hide resolved
| ### Support for custom spans and attributes: | ||
| While automatic instrumentation covers the platform interactions, we know you need visibility into your own application logic too. We're working to support the [OpenTelemetry API](https://www.npmjs.com/package/@opentelemetry/api) to make it easier for you to instrument custom spans within your application. | ||
|
|
||
| ### No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a section here explaining Missing Root Spans/Trace in progress so I can link to it from the UI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe in a different section? That isn't a known limitation so much as "how tracing works"
src/content/docs/workers/observability/exporting-opentelemetry-data/grafana-cloud.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/workers/observability/exporting-opentelemetry-data/grafana-cloud.mdx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor updates on the steps to extract Auth headers
src/content/docs/workers/observability/traces/spans-and-attributes.mdx
Outdated
Show resolved
Hide resolved
- Corrected links in the known limitations section to point to the appropriate security model documentation. - Updated span and attribute references to reflect changes in the Durable Object Storage API, including renaming and correcting links for various methods.
- Corrected the link for the Durable Object Storage SQL API to point to the correct SQLite storage API documentation. - Ensured consistency in the references to OpenTelemetry and observability platforms.
- Added `head_sampling_rate` and `persist` options for traces and logs in the OpenTelemetry configuration example. - Improved clarity in the tracing documentation regarding default sampling rates and configuration options.
…on documentation - Updated the Datadog entry to include a direct link to the official documentation. - Enhanced comments for clarity regarding the optional disabling of traces and logs in the Cloudflare dashboard.
* Update spans-and-attributes.mdx Add explanation for sequence number and remove attributes for durable_object_subrequest that we do not have yet * Update spans-and-attributes.mdx Also remove cold start since we do not have that info yet
src/content/docs/workers/observability/traces/spans-and-attributes.mdx
Outdated
Show resolved
Hide resolved
- Clarified the format for the Sentry authentication header in the OpenTelemetry data exporting instructions. - Updated attribute names in spans-and-attributes documentation to include the correct units for CPU and wall time.
…ation - Updated the formatting of the Sentry authentication header description to ensure proper usage of curly braces around the public key placeholder in the OpenTelemetry data exporting instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🎸 🐐 🚢
Summary
-draft PR for tracing / exporting OTel docs
Documentation checklist